blob: 460f5c343149bccf050014511205d4e1363cb800 [file] [log] [blame]
# Copyright 2016 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style
# license that can be found in the LICENSE file or at
# https://developers.google.com/open-source/licenses/bsd
"""Tests for the API v1 helpers."""
from __future__ import print_function
from __future__ import division
from __future__ import absolute_import
import datetime
import mock
import unittest
from framework import framework_constants
from framework import permissions
from framework import profiler
from services import api_pb2_v1_helpers
from services import service_manager
from proto import api_pb2_v1
from proto import project_pb2
from proto import tracker_pb2
from proto import usergroup_pb2
from testing import fake
from tracker import tracker_bizobj
def MakeTemplate(prefix):
return tracker_pb2.TemplateDef(
name='%s-template' % prefix,
content='%s-content' % prefix,
summary='%s-summary' % prefix,
summary_must_be_edited=True,
status='New',
labels=['%s-label1' % prefix, '%s-label2' % prefix],
members_only=True,
owner_defaults_to_member=True,
component_required=True,
)
def MakeLabel(prefix):
return tracker_pb2.LabelDef(
label='%s-label' % prefix,
label_docstring='%s-description' % prefix
)
def MakeStatus(prefix):
return tracker_pb2.StatusDef(
status='%s-New' % prefix,
means_open=True,
status_docstring='%s-status' % prefix
)
def MakeProjectIssueConfig(prefix):
return tracker_pb2.ProjectIssueConfig(
restrict_to_known=True,
default_col_spec='ID Type Priority Summary',
default_sort_spec='ID Priority',
well_known_statuses=[
MakeStatus('%s-status1' % prefix),
MakeStatus('%s-status2' % prefix),
],
well_known_labels=[
MakeLabel('%s-label1' % prefix),
MakeLabel('%s-label2' % prefix),
],
default_template_for_developers=1,
default_template_for_users=2
)
def MakeProject(prefix):
return project_pb2.MakeProject(
project_name='%s-project' % prefix,
summary='%s-summary' % prefix,
description='%s-description' % prefix,
)
class ApiV1HelpersTest(unittest.TestCase):
def setUp(self):
self.services = service_manager.Services(
user=fake.UserService(),
issue=fake.IssueService(),
project=fake.ProjectService(),
config=fake.ConfigService(),
issue_star=fake.IssueStarService())
self.services.user.TestAddUser('user@example.com', 111)
self.person_1 = api_pb2_v1_helpers.convert_person(111, None, self.services)
def testConvertTemplate(self):
"""Test convert_template."""
template = MakeTemplate('test')
prompt = api_pb2_v1_helpers.convert_template(template)
self.assertEqual(template.name, prompt.name)
self.assertEqual(template.summary, prompt.title)
self.assertEqual(template.content, prompt.description)
self.assertEqual(template.summary_must_be_edited, prompt.titleMustBeEdited)
self.assertEqual(template.status, prompt.status)
self.assertEqual(template.labels, prompt.labels)
self.assertEqual(template.members_only, prompt.membersOnly)
self.assertEqual(template.owner_defaults_to_member, prompt.defaultToMember)
self.assertEqual(template.component_required, prompt.componentRequired)
def testConvertLabel(self):
"""Test convert_label."""
labeldef = MakeLabel('test')
label = api_pb2_v1_helpers.convert_label(labeldef)
self.assertEqual(labeldef.label, label.label)
self.assertEqual(labeldef.label_docstring, label.description)
def testConvertStatus(self):
"""Test convert_status."""
statusdef = MakeStatus('test')
status = api_pb2_v1_helpers.convert_status(statusdef)
self.assertEqual(statusdef.status, status.status)
self.assertEqual(statusdef.means_open, status.meansOpen)
self.assertEqual(statusdef.status_docstring, status.description)
def testConvertProjectIssueConfig(self):
"""Test convert_project_config."""
prefix = 'test'
config = MakeProjectIssueConfig(prefix)
templates = [
MakeTemplate('%s-template1' % prefix),
MakeTemplate('%s-template2' % prefix),
]
config_api = api_pb2_v1_helpers.convert_project_config(config, templates)
self.assertEqual(config.restrict_to_known, config_api.restrictToKnown)
self.assertEqual(config.default_col_spec.split(), config_api.defaultColumns)
self.assertEqual(
config.default_sort_spec.split(), config_api.defaultSorting)
self.assertEqual(2, len(config_api.statuses))
self.assertEqual(2, len(config_api.labels))
self.assertEqual(2, len(config_api.prompts))
self.assertEqual(
config.default_template_for_developers,
config_api.defaultPromptForMembers)
self.assertEqual(
config.default_template_for_users,
config_api.defaultPromptForNonMembers)
def testConvertProject(self):
"""Test convert_project."""
project = MakeProject('testprj')
prefix = 'testconfig'
config = MakeProjectIssueConfig(prefix)
role = api_pb2_v1.Role.owner
templates = [
MakeTemplate('%s-template1' % prefix),
MakeTemplate('%s-template2' % prefix),
]
project_api = api_pb2_v1_helpers.convert_project(project, config, role,
templates)
self.assertEqual(project.project_name, project_api.name)
self.assertEqual(project.project_name, project_api.externalId)
self.assertEqual('/p/%s/' % project.project_name, project_api.htmlLink)
self.assertEqual(project.summary, project_api.summary)
self.assertEqual(project.description, project_api.description)
self.assertEqual(role, project_api.role)
self.assertIsInstance(
project_api.issuesConfig, api_pb2_v1.ProjectIssueConfig)
def testConvertPerson(self):
"""Test convert_person."""
result = api_pb2_v1_helpers.convert_person(111, None, self.services)
self.assertIsInstance(result, api_pb2_v1.AtomPerson)
self.assertEqual('user@example.com', result.name)
none_user = api_pb2_v1_helpers.convert_person(None, '', self.services)
self.assertIsNone(none_user)
deleted_user = api_pb2_v1_helpers.convert_person(
framework_constants.DELETED_USER_ID, '', self.services)
self.assertEqual(
deleted_user,
api_pb2_v1.AtomPerson(
kind='monorail#issuePerson',
name=framework_constants.DELETED_USER_NAME))
def testConvertIssueIDs(self):
"""Test convert_issue_ids."""
issue1 = fake.MakeTestIssue(789, 1, 'one', 'New', 111)
self.services.issue.TestAddIssue(issue1)
issue_ids = [100001]
mar = mock.Mock()
mar.cnxn = None
mar.project_name = 'test-project'
result = api_pb2_v1_helpers.convert_issue_ids(issue_ids, mar, self.services)
self.assertEqual(1, len(result))
self.assertEqual(1, result[0].issueId)
def testConvertIssueRef(self):
"""Test convert_issueref_pbs."""
issue1 = fake.MakeTestIssue(12345, 1, 'one', 'New', 111)
self.services.issue.TestAddIssue(issue1)
self.services.project.TestAddProject(
'test-project', owner_ids=[2],
project_id=12345)
mar = mock.Mock()
mar.cnxn = None
mar.project_name = 'test-project'
mar.project_id = 12345
ir = api_pb2_v1.IssueRef(
issueId=1,
projectId='test-project'
)
result = api_pb2_v1_helpers.convert_issueref_pbs([ir], mar, self.services)
self.assertEqual(1, len(result))
self.assertEqual(100001, result[0])
def testConvertIssue(self):
"""Convert an internal Issue PB to an IssueWrapper API PB."""
self.services.project.TestAddProject(
'test-project', owner_ids=[2], project_id=12345)
self.services.user.TestAddUser('user@example.com', 111)
mar = mock.Mock()
mar.cnxn = None
mar.project_name = 'test-project'
mar.project_id = 12345
mar.auth.effective_ids = {111}
mar.perms = permissions.READ_ONLY_PERMISSIONSET
mar.profiler = profiler.Profiler()
mar.config = tracker_bizobj.MakeDefaultProjectIssueConfig(12345)
mar.config.field_defs = [
tracker_bizobj.MakeFieldDef(
1, 12345, 'EstDays', tracker_pb2.FieldTypes.INT_TYPE, None, None,
False, False, False, None, None, None, False, None, None, None,
None, 'doc', False, approval_id=2),
tracker_bizobj.MakeFieldDef(
2, 12345, 'DesignReview', tracker_pb2.FieldTypes.APPROVAL_TYPE,
None, None, False, False, False, None, None, None, False, None,
None, None, None, 'doc', False),
tracker_bizobj.MakeFieldDef(
3, 12345, 'StringField', tracker_pb2.FieldTypes.STR_TYPE, None,
None, False, False, False, None, None, None, False, None, None,
None, None, 'doc', False),
tracker_bizobj.MakeFieldDef(
4, 12345, 'DressReview', tracker_pb2.FieldTypes.APPROVAL_TYPE,
None, None, False, False, False, None, None, None, False, None,
None, None, None, 'doc', False),
]
self.services.config.StoreConfig(mar.cnxn, mar.config)
now = 1472067725
now_dt = datetime.datetime.fromtimestamp(now)
fvs = [
tracker_bizobj.MakeFieldValue(
1, 4, None, None, None, None, False, phase_id=4),
tracker_bizobj.MakeFieldValue(
3, None, 'string', None, None, None, False, phase_id=4),
# missing phase
tracker_bizobj.MakeFieldValue(
3, None, u'\xe2\x9d\xa4\xef\xb8\x8f', None, None, None, False,
phase_id=2),
]
phases = [
tracker_pb2.Phase(phase_id=3, name="JustAPhase", rank=4),
tracker_pb2.Phase(phase_id=4, name="NotAPhase", rank=9)
]
approval_values = [
tracker_pb2.ApprovalValue(
approval_id=2, phase_id=3, approver_ids=[111]),
tracker_pb2.ApprovalValue(approval_id=4, approver_ids=[111])
]
issue = fake.MakeTestIssue(
12345, 1, 'one', 'New', 111, field_values=fvs,
approval_values=approval_values, phases=phases)
issue.opened_timestamp = now
issue.owner_modified_timestamp = now
issue.status_modified_timestamp = now
issue.component_modified_timestamp = now
# TODO(jrobbins): set up a lot more fields.
for cls in [api_pb2_v1.IssueWrapper, api_pb2_v1.IssuesGetInsertResponse]:
result = api_pb2_v1_helpers.convert_issue(cls, issue, mar, self.services)
self.assertEqual(1, result.id)
self.assertEqual('one', result.title)
self.assertEqual('one', result.summary)
self.assertEqual(now_dt, result.published)
self.assertEqual(now_dt, result.owner_modified)
self.assertEqual(now_dt, result.status_modified)
self.assertEqual(now_dt, result.component_modified)
self.assertEqual(
result.fieldValues, [
api_pb2_v1.FieldValue(
fieldName='EstDays',
fieldValue='4',
approvalName='DesignReview',
derived=False),
api_pb2_v1.FieldValue(
fieldName='StringField',
fieldValue='string',
phaseName="NotAPhase",
derived=False),
api_pb2_v1.FieldValue(
fieldName='StringField',
fieldValue=u'\xe2\x9d\xa4\xef\xb8\x8f',
derived=False),
])
self.assertEqual(
result.approvalValues,
[api_pb2_v1.Approval(
approvalName="DesignReview",
approvers=[self.person_1],
status=api_pb2_v1.ApprovalStatus.notSet,
phaseName="JustAPhase",
),
api_pb2_v1.Approval(
approvalName="DressReview",
approvers=[self.person_1],
status=api_pb2_v1.ApprovalStatus.notSet,
)]
)
self.assertEqual(
result.phases,
[api_pb2_v1.Phase(phaseName="JustAPhase", rank=4),
api_pb2_v1.Phase(phaseName="NotAPhase", rank=9)
])
# TODO(jrobbins): check a lot more fields.
def testConvertAttachment(self):
"""Test convert_attachment."""
attachment = tracker_pb2.Attachment(
attachment_id=1,
filename='stats.txt',
filesize=12345,
mimetype='text/plain',
deleted=False)
result = api_pb2_v1_helpers.convert_attachment(attachment)
self.assertEqual(attachment.attachment_id, result.attachmentId)
self.assertEqual(attachment.filename, result.fileName)
self.assertEqual(attachment.filesize, result.fileSize)
self.assertEqual(attachment.mimetype, result.mimetype)
self.assertEqual(attachment.deleted, result.isDeleted)
def testConvertAmendments(self):
"""Test convert_amendments."""
self.services.user.TestAddUser('user2@example.com', 222)
mar = mock.Mock()
mar.cnxn = None
issue = mock.Mock()
issue.project_name = 'test-project'
amendment_summary = tracker_pb2.Amendment(
field=tracker_pb2.FieldID.SUMMARY,
newvalue='new summary')
amendment_status = tracker_pb2.Amendment(
field=tracker_pb2.FieldID.STATUS,
newvalue='new status')
amendment_owner = tracker_pb2.Amendment(
field=tracker_pb2.FieldID.OWNER,
added_user_ids=[111])
amendment_labels = tracker_pb2.Amendment(
field=tracker_pb2.FieldID.LABELS,
newvalue='label1 -label2')
amendment_cc_add = tracker_pb2.Amendment(
field=tracker_pb2.FieldID.CC,
added_user_ids=[111])
amendment_cc_remove = tracker_pb2.Amendment(
field=tracker_pb2.FieldID.CC,
removed_user_ids=[222])
amendment_blockedon = tracker_pb2.Amendment(
field=tracker_pb2.FieldID.BLOCKEDON,
newvalue='1')
amendment_blocking = tracker_pb2.Amendment(
field=tracker_pb2.FieldID.BLOCKING,
newvalue='other:2 -3')
amendment_mergedinto = tracker_pb2.Amendment(
field=tracker_pb2.FieldID.MERGEDINTO,
newvalue='4')
amendments = [
amendment_summary, amendment_status, amendment_owner,
amendment_labels, amendment_cc_add, amendment_cc_remove,
amendment_blockedon, amendment_blocking, amendment_mergedinto]
result = api_pb2_v1_helpers.convert_amendments(
issue, amendments, mar, self.services)
self.assertEqual(amendment_summary.newvalue, result.summary)
self.assertEqual(amendment_status.newvalue, result.status)
self.assertEqual('user@example.com', result.owner)
self.assertEqual(['label1', '-label2'], result.labels)
self.assertEqual(['user@example.com', '-user2@example.com'], result.cc)
self.assertEqual(['test-project:1'], result.blockedOn)
self.assertEqual(['other:2', '-test-project:3'], result.blocking)
self.assertEqual(amendment_mergedinto.newvalue, result.mergedInto)
def testConvertApprovalAmendments(self):
"""Test convert_approval_comment."""
self.services.user.TestAddUser('user1@example.com', 111)
self.services.user.TestAddUser('user2@example.com', 222)
self.services.user.TestAddUser('user3@example.com', 333)
mar = mock.Mock()
mar.cnxn = None
amendment_status = tracker_bizobj.MakeApprovalStatusAmendment(
tracker_pb2.ApprovalStatus.APPROVED)
amendment_approvers = tracker_bizobj.MakeApprovalApproversAmendment(
[111, 222], [333])
amendments = [amendment_status, amendment_approvers]
result = api_pb2_v1_helpers.convert_approval_amendments(
amendments, mar, self.services)
self.assertEqual(amendment_status.newvalue, result.status)
self.assertEqual(
['user1@example.com', 'user2@example.com', '-user3@example.com'],
result.approvers)
def testConvertComment(self):
"""Test convert_comment."""
mar = mock.Mock()
mar.cnxn = None
mar.perms = permissions.PermissionSet([])
issue = fake.MakeTestIssue(project_id=12345, local_id=1, summary='sum',
status='New', owner_id=1001)
comment = tracker_pb2.IssueComment(
user_id=111,
content='test content',
sequence=1,
deleted_by=111,
timestamp=1437700000,
)
result = api_pb2_v1_helpers.convert_comment(
issue, comment, mar, self.services, None)
self.assertEqual('user@example.com', result.author.name)
self.assertEqual(comment.content, result.content)
self.assertEqual('user@example.com', result.deletedBy.name)
self.assertEqual(1, result.id)
# Ensure that the published timestamp falls in a timestamp range to account
# for the test being run in different timezones.
# Using "Fri, 23 Jul 2015 00:00:00" and "Fri, 25 Jul 2015 00:00:00".
self.assertTrue(
datetime.datetime(2015, 7, 23, 0, 0, 0) <= result.published <=
datetime.datetime(2015, 7, 25, 0, 0, 0))
self.assertEqual(result.kind, 'monorail#issueComment')
def testConvertApprovalComment(self):
"""Test convert_approval_comment."""
mar = mock.Mock()
mar.cnxn = None
mar.perms = permissions.PermissionSet([])
issue = fake.MakeTestIssue(project_id=12345, local_id=1, summary='sum',
status='New', owner_id=1001)
comment = tracker_pb2.IssueComment(
user_id=111,
content='test content',
sequence=1,
deleted_by=111,
timestamp=1437700000,
)
result = api_pb2_v1_helpers.convert_approval_comment(
issue, comment, mar, self.services, None)
self.assertEqual('user@example.com', result.author.name)
self.assertEqual(comment.content, result.content)
self.assertEqual('user@example.com', result.deletedBy.name)
self.assertEqual(1, result.id)
# Ensure that the published timestamp falls in a timestamp range to account
# for the test being run in different timezones.
# Using "Fri, 23 Jul 2015 00:00:00" and "Fri, 25 Jul 2015 00:00:00".
self.assertTrue(
datetime.datetime(2015, 7, 23, 0, 0, 0) <= result.published <=
datetime.datetime(2015, 7, 25, 0, 0, 0))
self.assertEqual(result.kind, 'monorail#approvalComment')
def testGetUserEmail(self):
email = api_pb2_v1_helpers._get_user_email(self.services.user, '', 111)
self.assertEqual('user@example.com', email)
no_user_found = api_pb2_v1_helpers._get_user_email(
self.services.user, '', 222)
self.assertEqual(framework_constants.USER_NOT_FOUND_NAME, no_user_found)
deleted = api_pb2_v1_helpers._get_user_email(
self.services.user, '', framework_constants.DELETED_USER_ID)
self.assertEqual(framework_constants.DELETED_USER_NAME, deleted)
none_user_id = api_pb2_v1_helpers._get_user_email(
self.services.user, '', None)
self.assertEqual(framework_constants.NO_USER_NAME, none_user_id)
def testSplitRemoveAdd(self):
"""Test split_remove_add."""
items = ['1', '-2', '-3', '4']
list_to_add, list_to_remove = api_pb2_v1_helpers.split_remove_add(items)
self.assertEqual(['1', '4'], list_to_add)
self.assertEqual(['2', '3'], list_to_remove)
def testIssueGlobalIDs(self):
"""Test issue_global_ids."""
issue1 = fake.MakeTestIssue(12345, 1, 'one', 'New', 111)
self.services.issue.TestAddIssue(issue1)
self.services.project.TestAddProject(
'test-project', owner_ids=[2],
project_id=12345)
mar = mock.Mock()
mar.cnxn = None
mar.project_name = 'test-project'
mar.project_id = 12345
pairs = ['test-project:1']
result = api_pb2_v1_helpers.issue_global_ids(
pairs, 12345, mar, self.services)
self.assertEqual(100001, result[0])
def testConvertGroupSettings(self):
"""Test convert_group_settings."""
setting = usergroup_pb2.MakeSettings('owners', 'mdb', 0)
result = api_pb2_v1_helpers.convert_group_settings('test-group', setting)
self.assertEqual('test-group', result.groupName)
self.assertEqual(setting.who_can_view_members, result.who_can_view_members)
self.assertEqual(setting.ext_group_type, result.ext_group_type)
self.assertEqual(setting.last_sync_time, result.last_sync_time)
def testConvertComponentDef(self):
pass # TODO(jrobbins): Fill in this test.
def testConvertComponentIDs(self):
pass # TODO(jrobbins): Fill in this test.
def testConvertFieldValues_Empty(self):
"""The client's request might not have any field edits."""
mar = mock.Mock()
mar.config = tracker_bizobj.MakeDefaultProjectIssueConfig(789)
field_values = []
actual = api_pb2_v1_helpers.convert_field_values(
field_values, mar, self.services)
(fv_list_add, fv_list_remove, fv_list_clear,
label_list_add, label_list_remove) = actual
self.assertEqual([], fv_list_add)
self.assertEqual([], fv_list_remove)
self.assertEqual([], fv_list_clear)
self.assertEqual([], label_list_add)
self.assertEqual([], label_list_remove)
def testConvertFieldValues_Normal(self):
"""The client wants to edit a custom field."""
mar = mock.Mock()
mar.config = tracker_bizobj.MakeDefaultProjectIssueConfig(789)
mar.config.field_defs = [
tracker_bizobj.MakeFieldDef(
1, 789, 'Priority', tracker_pb2.FieldTypes.ENUM_TYPE, None, None,
False, False, False, None, None, None, False, None, None, None,
None, 'doc', False),
tracker_bizobj.MakeFieldDef(
2, 789, 'EstDays', tracker_pb2.FieldTypes.INT_TYPE, None, None,
False, False, False, 0, 99, None, False, None, None, None,
None, 'doc', False),
tracker_bizobj.MakeFieldDef(
3, 789, 'Nickname', tracker_pb2.FieldTypes.STR_TYPE, None, None,
False, False, False, None, None, None, False, None, None, None,
None, 'doc', False),
tracker_bizobj.MakeFieldDef(
4, 789, 'Verifier', tracker_pb2.FieldTypes.USER_TYPE, None, None,
False, False, False, None, None, None, False, None, None, None,
None, 'doc', False),
tracker_bizobj.MakeFieldDef(
5, 789, 'Deadline', tracker_pb2.FieldTypes.DATE_TYPE, None, None,
False, False, False, None, None, None, False, None, None, None,
None, 'doc', False),
tracker_bizobj.MakeFieldDef(
6, 789, 'Homepage', tracker_pb2.FieldTypes.URL_TYPE, None, None,
False, False, False, None, None, None, False, None, None, None,
None, 'doc', False),
]
field_values = [
api_pb2_v1.FieldValue(fieldName='Priority', fieldValue='High'),
api_pb2_v1.FieldValue(fieldName='EstDays', fieldValue='4'),
api_pb2_v1.FieldValue(fieldName='Nickname', fieldValue='Scout'),
api_pb2_v1.FieldValue(
fieldName='Verifier', fieldValue='user@example.com'),
api_pb2_v1.FieldValue(fieldName='Deadline', fieldValue='2017-12-06'),
api_pb2_v1.FieldValue(
fieldName='Homepage', fieldValue='http://example.com'),
]
actual = api_pb2_v1_helpers.convert_field_values(
field_values, mar, self.services)
(fv_list_add, fv_list_remove, fv_list_clear,
label_list_add, label_list_remove) = actual
self.assertEqual(
[
tracker_bizobj.MakeFieldValue(2, 4, None, None, None, None, False),
tracker_bizobj.MakeFieldValue(
3, None, 'Scout', None, None, None, False),
tracker_bizobj.MakeFieldValue(
4, None, None, 111, None, None, False),
tracker_bizobj.MakeFieldValue(
5, None, None, None, 1512518400, None, False),
tracker_bizobj.MakeFieldValue(
6, None, None, None, None, 'http://example.com', False),
], fv_list_add)
self.assertEqual([], fv_list_remove)
self.assertEqual([], fv_list_clear)
self.assertEqual(['Priority-High'], label_list_add)
self.assertEqual([], label_list_remove)
def testConvertFieldValues_ClearAndRemove(self):
"""The client wants to clear and remove some custom fields."""
mar = mock.Mock()
mar.config = tracker_bizobj.MakeDefaultProjectIssueConfig(789)
mar.config.field_defs = [
tracker_bizobj.MakeFieldDef(
1, 789, 'Priority', tracker_pb2.FieldTypes.ENUM_TYPE, None, None,
False, False, False, None, None, None, False, None, None, None,
None, 'doc', False),
tracker_bizobj.MakeFieldDef(
11, 789, 'OS', tracker_pb2.FieldTypes.ENUM_TYPE, None, None,
False, False, False, None, None, None, False, None, None, None,
None, 'doc', False),
tracker_bizobj.MakeFieldDef(
2, 789, 'EstDays', tracker_pb2.FieldTypes.INT_TYPE, None, None,
False, False, False, 0, 99, None, False, None, None, None,
None, 'doc', False),
tracker_bizobj.MakeFieldDef(
3, 789, 'Nickname', tracker_pb2.FieldTypes.STR_TYPE, None, None,
False, False, False, None, None, None, False, None, None, None,
None, 'doc', False),
]
field_values = [
api_pb2_v1.FieldValue(
fieldName='Priority', fieldValue='High',
operator=api_pb2_v1.FieldValueOperator.remove),
api_pb2_v1.FieldValue(
fieldName='OS', operator=api_pb2_v1.FieldValueOperator.clear),
api_pb2_v1.FieldValue(
fieldName='EstDays', operator=api_pb2_v1.FieldValueOperator.clear),
api_pb2_v1.FieldValue(
fieldName='Nickname', fieldValue='Scout',
operator=api_pb2_v1.FieldValueOperator.remove),
]
actual = api_pb2_v1_helpers.convert_field_values(
field_values, mar, self.services)
(fv_list_add, fv_list_remove, fv_list_clear,
label_list_add, label_list_remove) = actual
self.assertEqual([], fv_list_add)
self.assertEqual(
[
tracker_bizobj.MakeFieldValue(
3, None, 'Scout', None, None, None, False)
], fv_list_remove)
self.assertEqual([11, 2], fv_list_clear)
self.assertEqual([], label_list_add)
self.assertEqual(['Priority-High'], label_list_remove)
def testConvertFieldValues_Errors(self):
"""We don't crash on bad requests."""
mar = mock.Mock()
mar.config = tracker_bizobj.MakeDefaultProjectIssueConfig(789)
mar.config.field_defs = [
tracker_bizobj.MakeFieldDef(
2, 789, 'EstDays', tracker_pb2.FieldTypes.INT_TYPE, None, None,
False, False, False, 0, 99, None, False, None, None, None,
None, 'doc', False),
]
field_values = [
api_pb2_v1.FieldValue(
fieldName='Unknown', operator=api_pb2_v1.FieldValueOperator.clear),
]
actual = api_pb2_v1_helpers.convert_field_values(
field_values, mar, self.services)
(fv_list_add, fv_list_remove, fv_list_clear,
label_list_add, label_list_remove) = actual
self.assertEqual([], fv_list_add)
self.assertEqual([], fv_list_remove)
self.assertEqual([], fv_list_clear)
self.assertEqual([], label_list_add)
self.assertEqual([], label_list_remove)
def testConvertApprovals(self):
"""Test we can convert ApprovalValues."""
cnxn = None
config = tracker_bizobj.MakeDefaultProjectIssueConfig(789)
config.field_defs = [
tracker_bizobj.MakeFieldDef(
1, 789, 'DesignReview', tracker_pb2.FieldTypes.APPROVAL_TYPE, None,
None, False, False, False, None, None, None, False, None, None,
None, None, 'doc', False),
tracker_bizobj.MakeFieldDef(
2, 789, 'PrivacyReview', tracker_pb2.FieldTypes.APPROVAL_TYPE, None,
None, False, False, False, 0, 99, None, False, None, None, None,
None, 'doc', False),
tracker_bizobj.MakeFieldDef(
5, 789, 'UXReview', tracker_pb2.FieldTypes.APPROVAL_TYPE, None,
None, False, False, False, None, None, None, False, None, None,
None, None, 'doc', False),
tracker_bizobj.MakeFieldDef(
6, 789, 'Homepage', tracker_pb2.FieldTypes.URL_TYPE, None, None,
False, False, False, None, None, None, False, None, None, None,
None, 'doc', False),
]
phases = [
tracker_pb2.Phase(phase_id=1),
tracker_pb2.Phase(phase_id=2, name="JustAPhase", rank=3),
]
ts = 1536260059
expected = [
api_pb2_v1.Approval(
approvalName="DesignReview",
approvers=[self.person_1],
setter=self.person_1,
status=api_pb2_v1.ApprovalStatus.needsReview,
setOn=datetime.datetime.fromtimestamp(ts),
),
api_pb2_v1.Approval(
approvalName="UXReview",
approvers=[self.person_1],
status=api_pb2_v1.ApprovalStatus.notSet,
phaseName="JustAPhase",
),
]
avs = [
tracker_pb2.ApprovalValue(
approval_id=1, approver_ids=[111], setter_id=111,
status=tracker_pb2.ApprovalStatus.NEEDS_REVIEW, set_on=ts),
tracker_pb2.ApprovalValue(
approval_id=5, approver_ids=[111], phase_id=2)
]
actual = api_pb2_v1_helpers.convert_approvals(
cnxn, avs, self.services, config, phases)
self.assertEqual(actual, expected)
def testConvertApprovals_errors(self):
"""we dont crash on bad requests."""
cnxn = None
config = tracker_bizobj.MakeDefaultProjectIssueConfig(789)
config.field_defs = [
tracker_bizobj.MakeFieldDef(
1, 789, 'DesignReview', tracker_pb2.FieldTypes.APPROVAL_TYPE, None,
None, False, False, False, None, None, None, False, None, None,
None, None, 'doc', False),
tracker_bizobj.MakeFieldDef(
5, 789, 'UXReview', tracker_pb2.FieldTypes.APPROVAL_TYPE, None,
None, False, False, False, None, None, None, False, None, None,
None, None, 'doc', False),
tracker_bizobj.MakeFieldDef(
3, 789, 'DesignDoc', tracker_pb2.FieldTypes.URL_TYPE, None, None,
False, False, False, 0, 99, None, False, None, None, None,
None, 'doc', False),
]
phases = []
avs = [
tracker_pb2.ApprovalValue(approval_id=1, approver_ids=[111]),
# phase does not exist
tracker_pb2.ApprovalValue(approval_id=2, phase_id=2),
tracker_pb2.ApprovalValue(approval_id=3), # field 3 is not an approval
tracker_pb2.ApprovalValue(approval_id=4), # field 4 does not exist
]
expected = [
api_pb2_v1.Approval(
approvalName="DesignReview",
approvers=[self.person_1],
status=api_pb2_v1.ApprovalStatus.notSet)
]
actual = api_pb2_v1_helpers.convert_approvals(
cnxn, avs, self.services, config, phases)
self.assertEqual(actual, expected)
def testConvertPhases(self):
"""We can convert Phases."""
phases = [
tracker_pb2.Phase(name="JustAPhase", rank=1),
tracker_pb2.Phase(name="Can'tPhaseMe", rank=4),
tracker_pb2.Phase(phase_id=11, rank=5),
tracker_pb2.Phase(rank=3),
tracker_pb2.Phase(name="Phase"),
]
expected = [
api_pb2_v1.Phase(phaseName="JustAPhase", rank=1),
api_pb2_v1.Phase(phaseName="Can'tPhaseMe", rank=4),
api_pb2_v1.Phase(phaseName="Phase"),
]
actual = api_pb2_v1_helpers.convert_phases(phases)
self.assertEqual(actual, expected)