commit 53f7a7f6a3ec8b4ce49984678d77ca56e1f990b7
author Adrià Vilanova Martínez <me@avm99963.com> Mon May 30 13:59:59 2022 +0200
committer Adrià Vilanova Martínez <me@avm99963.com> Tue May 31 11:03:06 2022 +0200
tree 70d71ef8c5e7cde9e854cecd3051ca1d48f48607
parent 8b63fb37c011d2be893bb3cc9ef4eb756f631924

Change how the options are handled

Now the options are parsed by a single function in the Options class,
streamlining how they are interpreted in different parts of the code
(background page and the options page).

Bug: translateselectedtext:11
Change-Id: I1696da55c8c8d99683a0f45080b59849f9d4be4f

src/options/elements/options-editor/options-editor.js

diff --git a/src/options/elements/options-editor/options-editor.js b/src/options/elements/options-editor/options-editor.js
index 9e32dfa..b7eeb52 100644
--- a/src/options/elements/options-editor/options-editor.js
+++ b/src/options/elements/options-editor/options-editor.js
@@ -2,31 +2,11 @@
 import {map} from 'lit/directives/map.js';
 
 import {msg} from '../../../common/i18n.js';
+import {TAB_OPTIONS} from '../../../common/options.js';
 import {SHARED_STYLES} from '../../shared/shared-styles.js';
 
 import LanguagesEditor from './languages-editor.js';
 
-const TAB_OPTIONS = [
-  // Open in new tab for each translation
-  {
-    value: '',
-    labelMsg: 'options_tabsoption_1',
-    deprecatedValues: [],
-  },
-  // Open in a unique tab
-  {
-    value: 'yep',
-    labelMsg: 'options_tabsoption_2',
-    deprecatedValues: [],
-  },
-  // Open in a popup
-  {
-    value: 'popup',
-    labelMsg: 'options_tabsoption_3',
-    deprecatedValues: ['panel'],
-  },
-];
-
 export class OptionsEditor extends LitElement {
   static properties = {
     storageData: {type: Object},
@@ -58,7 +38,7 @@
       return html`
             <p>
               <input type="radio" name="uniquetab" id="uniquetab_${i}"
-                  value="${option?.value}" ?checked="${checked}"
+                  value="${option?.value}" .checked="${checked}"
                   @change="${() => this.changeTabOption(option.value)}">
               <label for="uniquetab_${i}">${msg(option.labelMsg)}</label></p>
           `;