commit 51f151f92ceb51d6e23bdf0a31d5fb26bbb5198f
author Adrià Vilanova Martínez <me@avm99963.com> Wed Jun 01 23:17:38 2022 +0200
committer Adrià Vilanova Martínez <me@avm99963.com> Wed Jun 01 23:17:38 2022 +0200
tree f9f45aef01ea0a3ce0dca9c425e02d64a1e12f88
parent bbd9ecc6bbfc2b7d9d02bfc1ce25f050f0d248a7

Minor changes to background.ts suggested by eslint

Change-Id: Ib7d907556901a19ac6bcdab969633b40aa1528d7

src/background.ts

diff --git a/src/background.ts b/src/background.ts
index 699109d..941e198 100644
--- a/src/background.ts
+++ b/src/background.ts
@@ -8,7 +8,7 @@
 }
 
 function getTranslationUrl(lang: string, text: string): string {
-  let params = new URLSearchParams({
+  const params = new URLSearchParams({
     sl: 'auto',
     tl: lang,
     text: text,
@@ -17,17 +17,17 @@
   return 'https://translate.google.com/?' + params.toString();
 }
 
-function translationClick(
-    info: chrome.contextMenus.OnClickData, tab: chrome.tabs.Tab): void {
-  let optionsPromise = Options.getOptions();
-  let ssPromise = ExtSessionStorage.get(['contextMenuLangs', 'translatorTab']);
+function translationClick(info: chrome.contextMenus.OnClickData): void {
+  const optionsPromise = Options.getOptions();
+  const ssPromise =
+      ExtSessionStorage.get(['contextMenuLangs', 'translatorTab']);
   Promise.all([optionsPromise, ssPromise])
       .then(returnValues => {
         const [options, sessionStorageItems] = returnValues;
-        let url = getTranslationUrl(
+        const url = getTranslationUrl(
             sessionStorageItems.contextMenuLangs?.[info.menuItemId],
             info.selectionText);
-        let settings_tab = {url};
+        const settings_tab = {url};
         if (sessionStorageItems.translatorTab && options.uniqueTab == 'yep') {
           chrome.tabs.update(
               sessionStorageItems.translatorTab, settings_tab, tab => {
@@ -63,9 +63,9 @@
 function createMenus(options: Options): Promise<void> {
   chrome.contextMenus.removeAll();
 
-  let contextMenuLangs: ContextMenuLangs = {};
-  let langs = options.targetLangs;
-  let isSingleEntry = Object.values(langs).length == 1;
+  const contextMenuLangs: ContextMenuLangs = {};
+  const langs = options.targetLangs;
+  const isSingleEntry = Object.values(langs).length == 1;
 
   let parentEl;
   if (!isSingleEntry) {
@@ -76,8 +76,8 @@
     });
   }
 
-  for (let [index, language] of Object.entries(langs)) {
-    let languageDetails = isoLangs[language];
+  for (const language of Object.values(langs)) {
+    const languageDetails = isoLangs[language];
     if (languageDetails === undefined) {
       console.error(language + ' doesn\'t exist!');
       continue;
@@ -89,7 +89,7 @@
     } else {
       title = languageDetails.name + ' (' + languageDetails.nativeName + ')';
     }
-    let id = chrome.contextMenus.create({
+    const id = chrome.contextMenus.create({
       'id': 'tr_language_' + language,
       'title': title,
       'parentId': parentEl,
@@ -158,15 +158,15 @@
   chrome.notifications.clear(notification_id);
 });
 
-chrome.contextMenus.onClicked.addListener((info, tab) => {
+chrome.contextMenus.onClicked.addListener(info => {
   if (info.menuItemId == 'tr_options') {
     chrome.runtime.openOptionsPage();
   } else {
-    translationClick(info, tab);
+    translationClick(info);
   }
 });
 
-chrome.tabs.onRemoved.addListener((tabId, removeInfo) => {
+chrome.tabs.onRemoved.addListener(tabId => {
   ExtSessionStorage.get('translatorTab')
       .then(items => {
         if (tabId == items.translatorTab) {
@@ -180,14 +180,15 @@
   chrome.runtime.openOptionsPage();
 });
 
-chrome.runtime.onMessage.addListener((request, sender, sendResponse) => {
+chrome.runtime.onMessage.addListener(request => {
   switch (request.action) {
     case 'clearTranslatorTab':
       ExtSessionStorage.set({translatorTab: null});
       break;
 
     default:
-      console.error(`Unknown action "${request.action}" received as a message.`);
+      console.error(
+          `Unknown action "${request.action}" received as a message.`);
   }
 
   return undefined;