Merge branch 'main' into avm99963-monorail
Merged commit 34d8229ae2b51fb1a15bd208e6fe6185c94f6266
GitOrigin-RevId: 7ee0917f93a577e475f8e09526dd144d245593f4
diff --git a/tracker/test/webcomponentspage_test.py b/tracker/test/webcomponentspage_test.py
index 65cfc66..86d3606 100644
--- a/tracker/test/webcomponentspage_test.py
+++ b/tracker/test/webcomponentspage_test.py
@@ -1,7 +1,6 @@
-# Copyright 2020 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style
-# license that can be found in the LICENSE file or at
-# https://developers.google.com/open-source/licenses/bsd
+# Copyright 2020 The Chromium Authors
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
"""Tests for the Monorail SPA pages, as served by EZT."""
from __future__ import print_function
from __future__ import division
@@ -10,12 +9,9 @@
import mock
import unittest
-import ezt
-import settings
-from framework import permissions
-from proto import project_pb2
-from proto import site_pb2
+from framework import exceptions
+from mrproto import project_pb2
from services import service_manager
from tracker import webcomponentspage
from testing import fake
@@ -35,8 +31,7 @@
self.hotlist = self.services.features.TestAddHotlist(
'HotlistName', summary='summary', owner_ids=[111], hotlist_id=1236)
- self.servlet = webcomponentspage.WebComponentsPage(
- 'req', 'res', services=self.services)
+ self.servlet = webcomponentspage.WebComponentsPage(services=self.services)
def testHotlistPage_OldUiUrl(self):
mr = testing_helpers.MakeMonorailRequest(
@@ -76,8 +71,7 @@
self.project_a = self.services.project.TestAddProject('a', project_id=1)
self.project_b = self.services.project.TestAddProject('b', project_id=2)
- self.servlet = webcomponentspage.ProjectListPage(
- 'req', 'res', services=self.services)
+ self.servlet = webcomponentspage.ProjectListPage(services=self.services)
@mock.patch('settings.domain_to_default_project', {})
def testMaybeRedirectToDomainDefaultProject_NoMatch(self):
@@ -114,7 +108,6 @@
mr = testing_helpers.MakeMonorailRequest()
mr.request.host = 'example.com'
self.servlet.redirect = mock.Mock()
- msg = self.servlet._MaybeRedirectToDomainDefaultProject(mr)
- print('msg: ' + msg)
- self.assertTrue(msg.startswith('Redirected'))
- self.servlet.redirect.assert_called_once()
+ with self.assertRaises(exceptions.RedirectException) as e:
+ self.servlet._MaybeRedirectToDomainDefaultProject(mr)
+ self.assertIn('/p/a', str(e.exception))