Merge branch 'main' into avm99963-monorail
Merged commit 34d8229ae2b51fb1a15bd208e6fe6185c94f6266
GitOrigin-RevId: 7ee0917f93a577e475f8e09526dd144d245593f4
diff --git a/tracker/test/fltconversion_test.py b/tracker/test/fltconversion_test.py
index be66ad2..2526fdc 100644
--- a/tracker/test/fltconversion_test.py
+++ b/tracker/test/fltconversion_test.py
@@ -1,7 +1,6 @@
-# Copyright 2018 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style
-# license that can be found in the LICENSE file or at
-# https://developers.google.com/open-source/licenses/bsd
+# Copyright 2018 The Chromium Authors
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
"""Unittests for the flt launch issues conversion task."""
from __future__ import print_function
@@ -21,7 +20,7 @@
from tracker import tracker_bizobj
from testing import fake
from testing import testing_helpers
-from proto import tracker_pb2
+from mrproto import tracker_pb2
class FLTConvertTask(unittest.TestCase):
@@ -411,13 +410,13 @@
def testFetchAndAssertProjectInfo(self):
# test no 'launch' in request
- self.assertRaisesRegexp(
+ self.assertRaisesRegex(
AssertionError, r'bad launch type:',
self.task.FetchAndAssertProjectInfo, self.mr)
# test bad 'launch' in request
mr = testing_helpers.MakeMonorailRequest(path='url/url?launch=bad')
- self.assertRaisesRegexp(
+ self.assertRaisesRegex(
AssertionError, r'bad launch type: bad',
self.task.FetchAndAssertProjectInfo, mr)
@@ -429,7 +428,7 @@
# test no template
self.task.services.template.GetTemplateByName = mock.Mock(
return_value=None)
- self.assertRaisesRegexp(
+ self.assertRaisesRegex(
AssertionError, r'not found in chromium project',
self.task.FetchAndAssertProjectInfo, mr)
@@ -438,14 +437,14 @@
'template', 'sum', 'New', 111, 'content', [], [], [], [])
self.task.services.template.GetTemplateByName = mock.Mock(
return_value=template)
- self.assertRaisesRegexp(
+ self.assertRaisesRegex(
AssertionError, 'no approvals or phases in',
self.task.FetchAndAssertProjectInfo, mr)
# test phases not recognized
template.phases = [tracker_pb2.Phase(name='WeirdPhase')]
template.approval_values = [tracker_pb2.ApprovalValue()]
- self.assertRaisesRegexp(
+ self.assertRaisesRegex(
AssertionError, 'one or more phases not recognized',
self.task.FetchAndAssertProjectInfo, mr)
@@ -457,7 +456,7 @@
tracker_pb2.ApprovalValue(approval_id=3)]
# test approvals not recognized
- self.assertRaisesRegexp(
+ self.assertRaisesRegex(
AssertionError, 'one or more approvals not recognized',
self.task.FetchAndAssertProjectInfo, mr)
@@ -471,7 +470,7 @@
]
# test approvals not in config's approval_defs
- self.assertRaisesRegexp(
+ self.assertRaisesRegex(
AssertionError, 'one or more approvals not in config.approval_defs',
self.task.FetchAndAssertProjectInfo, mr)
@@ -481,7 +480,7 @@
tracker_pb2.ApprovalDef(approval_id=3)]
# test no pm field exists in project
- self.assertRaisesRegexp(
+ self.assertRaisesRegex(
AssertionError, 'project has no FieldDef %s' % fltconversion.PM_FIELD,
self.task.FetchAndAssertProjectInfo, mr)
@@ -496,7 +495,7 @@
])
# test no USER_TYPE te field exists in project
- self.assertRaisesRegexp(
+ self.assertRaisesRegex(
AssertionError, 'project has no FieldDef %s' % fltconversion.TE_FIELD,
self.task.FetchAndAssertProjectInfo, mr)
@@ -510,7 +509,7 @@
])
# test no M-Target INT_TYPE multivalued Phase FieldDefs
- self.assertRaisesRegexp(
+ self.assertRaisesRegex(
AssertionError,
'project has no FieldDef %s' % fltconversion.MTARGET_FIELD,
self.task.FetchAndAssertProjectInfo, mr)
@@ -519,7 +518,7 @@
self.config.field_defs[-2].is_multivalued = True
# test no M-Approved INT_TYPE multivalued Phase FieldDefs
- self.assertRaisesRegexp(
+ self.assertRaisesRegex(
AssertionError,
'project has no FieldDef %s' % fltconversion.MAPPROVED_FIELD,
self.task.FetchAndAssertProjectInfo, mr)
@@ -538,7 +537,7 @@
# FINCH special case
# test approvals for Finch not required
mr = testing_helpers.MakeMonorailRequest(path='url/url?launch=finch')
- self.assertRaisesRegexp(
+ self.assertRaisesRegex(
AssertionError, 'finch template not set up correctly',
self.task.FetchAndAssertProjectInfo, mr)
@@ -568,7 +567,7 @@
# test phases not recognized
template.phases = [tracker_pb2.Phase(name='Chrome-Test')]
template.approval_values = [tracker_pb2.ApprovalValue()]
- self.assertRaisesRegexp(
+ self.assertRaisesRegex(
AssertionError, 'one or more phases not recognized',
self.task.FetchAndAssertProjectInfo, mr)
@@ -580,7 +579,7 @@
tracker_pb2.ApprovalValue(approval_id=1),
tracker_pb2.ApprovalValue(approval_id=2),
tracker_pb2.ApprovalValue(approval_id=3)]
- self.assertRaisesRegexp(
+ self.assertRaisesRegex(
AssertionError, 'os template not set up correctly',
self.task.FetchAndAssertProjectInfo, mr)
@@ -588,7 +587,7 @@
av.status = tracker_pb2.ApprovalStatus.NEEDS_REVIEW
# test approvals not recognized
- self.assertRaisesRegexp(
+ self.assertRaisesRegex(
AssertionError, 'one or more approvals not recognized',
self.task.FetchAndAssertProjectInfo, mr)