commit 9dbe500e40d2ee88c9e4087bfc1a91f1ebb7d0f3
author Adrià Vilanova Martínez <me@avm99963.com> Mon Dec 04 00:06:09 2023 +0100
committer Copybara bot <copybara-bot@avm99963.com> Sun Dec 03 23:14:59 2023 +0000
tree b17ce97833670ce72a4e1a261d0c80ba501d14b8
parent b24c5eb23b734db805b208e51d0df9cf96122654

fix(workers): save affiliation status correctly

This issue didn't affect the functioning of the program because it would
only occur if the |$internal| flag was set to true (and it is never set
to true). Thus, this CL prevents this issue from happening in the
future.

GitOrigin-RevId: 7d2069d803675a2ab5ebeada30fbbd03ad112533

src/inc/workers.php

diff --git a/src/inc/workers.php b/src/inc/workers.php
index f004286..a180022 100644
--- a/src/inc/workers.php
+++ b/src/inc/workers.php
@@ -143,7 +143,8 @@
     $stime = (int)$day;
     $sstatus = (int)$status;
 
-    if ((!$internal && !in_array($sstatus, self::$affiliationStatusesManual)) || ($internal && !in_array($affiliationStatuses))) return false;
+    if (!$internal && !in_array($sstatus, self::$affiliationStatusesManual)) return false;
+    if ($internal && !in_array($sstatus, self::$affiliationStatuses)) return false;
 
     if (!workers::exists($sid)) return false;
 
@@ -157,7 +158,8 @@
     $stime = (int)$day;
     $sstatus = (int)$status;
 
-    if ((!$internal && !in_array($sstatus, self::$affiliationStatusesManual)) || ($internal && !in_array($affiliationStatuses))) return false;
+    if (!$internal && !in_array($sstatus, self::$affiliationStatusesManual)) return false;
+    if ($internal && !in_array($sstatus, self::$affiliationStatuses)) return false;
 
     if (!self::existsWorkHistoryItem($id)) return false;